Add main attribute owners to ASAtom#693
Conversation
📝 WalkthroughWalkthroughThree new public static final ASAtom constants (LAYOUT, LIST, and TABLE) were added to the ASAtom class in their respective alphabetically-organized sections, expanding the predefined set of atom name identifiers without modifying existing logic. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/main/java/org/verapdf/as/ASAtom.java (1)
355-355: Consider addingPrintFieldfor completeness of standard attribute owners.ISO 32000-2 (Table 378) lists five standard structure attribute owners: Layout, List, Table, PrintField, and Artifact.
Artifactis already present (line 79), and this PR adds the other three — butPrintFieldremains absent. If these constants are being added to support attribute-owner lookups in tagged-PDF validation, omittingPrintFieldmay require a follow-up PR.➕ Suggested addition in the P section (after `PRINT_SCALING`, line 480)
public static final ASAtom PRINT_SCALING = new ASAtom("PrintScaling"); + public static final ASAtom PRINT_FIELD = new ASAtom("PrintField"); public static final ASAtom PROC_SET = new ASAtom("ProcSet");Also applies to: 366-366, 573-573
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/java/org/verapdf/as/ASAtom.java` at line 355, The file is missing the standard attribute-owner constant for "PrintField"; add a new public static final ASAtom PRINTFIELD = new ASAtom("PrintField") to ASAtom so all ISO 32000-2 standard owners are present; place the constant in the P section (e.g., after the existing PRINT_SCALING entry) and ensure the identifier is PRINTFIELD and the string literal is exactly "PrintField" to match the other ASAtom constants (refer to existing constants like LAYOUT, LIST, TABLE, ARTIFACT for placement and naming style).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/main/java/org/verapdf/as/ASAtom.java`:
- Line 355: The file is missing the standard attribute-owner constant for
"PrintField"; add a new public static final ASAtom PRINTFIELD = new
ASAtom("PrintField") to ASAtom so all ISO 32000-2 standard owners are present;
place the constant in the P section (e.g., after the existing PRINT_SCALING
entry) and ensure the identifier is PRINTFIELD and the string literal is exactly
"PrintField" to match the other ASAtom constants (refer to existing constants
like LAYOUT, LIST, TABLE, ARTIFACT for placement and naming style).
2 participants
Summary by CodeRabbit